[UR][OPENCL] Eliminate usage of regex in opencl #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Intel/llvm testing here |
omarahmed1111
force-pushed
the
eliminate-usage-of-regex-in-opencl
branch
from
891ae49
to
2af233a
Compare
aarongreig
approved these changes
Nov 8, 2023
omarahmed1111
force-pushed
the
eliminate-usage-of-regex-in-opencl
branch
from
2af233a
to
02e8f48
Compare
omarahmed1111
force-pushed
the
eliminate-usage-of-regex-in-opencl
branch
from
02e8f48
to
63dfb35
Compare
kbenzie
added a commit
that referenced
this pull request
Nov 28, 2023
…in-opencl [UR][OPENCL] Eliminate usage of regex in opencl
kbenzie
added a commit
to kbenzie/llvm
that referenced
this pull request
Nov 29, 2023
Combines the follow UR changes: * oneapi-src/unified-runtime#1037 * oneapi-src/unified-runtime#1097 * oneapi-src/unified-runtime#1106 * oneapi-src/unified-runtime#1039 * oneapi-src/unified-runtime#993 * oneapi-src/unified-runtime#1088 Depends on intel#11893 merging first.
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Nov 29, 2023
Combines the follow UR changes: * oneapi-src/unified-runtime#1037 * oneapi-src/unified-runtime#1097 * oneapi-src/unified-runtime#1106 * oneapi-src/unified-runtime#1039 * oneapi-src/unified-runtime#1088 Depends on #11893 merging first.
callumfare
pushed a commit
to kbenzie/llvm
that referenced
this pull request
Dec 18, 2023
Combines the follow UR changes: * oneapi-src/unified-runtime#1037 * oneapi-src/unified-runtime#1097 * oneapi-src/unified-runtime#1106 * oneapi-src/unified-runtime#1039 * oneapi-src/unified-runtime#1088 Depends on intel#11893 merging first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of regex was downgrading the performance of opencl adapter strongly. Using Intel PIN tool, querying the total number of instructions using a custom pin tool, it reported that the affective number of instructions that was executed from inside
libpi_opencl.soto run simple-sycl-app was 269469 which is an order of magnitude higher than any other adapter. Analyzing this, most of these instructions was generated from the regex library. This was also definetly have a strong effect on the runtime performance of sycl-opencl applications.The changes in this PR will decrease the effective number of instructions executed in opencl adapter to ~12000 which is a reasonable number comparing it to other adapters (all are in the range of 10000 - ~20000).