Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify spec for QUEUE_INFO_SIZE and change testing for it accordingly. #1128

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Clarify spec for QUEUE_INFO_SIZE and change testing for it accordingly. #1128

merged 2 commits into from
Jun 12, 2024

Commits on May 30, 2024

  1. Clarify spec for QUEUE_INFO_SIZE and change testing for it accordingly. 

    Also correctly report lack of queue on device support in cuda and hip
adapters.
    @aarongreig @kbenzie
    aarongreig authored and kbenzie committed May 30, 2024
    Configuration menu
    Copy the full SHA
    51900ae View commit details
    Browse the repository at this point in the history

  2. Only test DEVICE_DEFAULT query when queue is device default. 

    Some supported CL drivers return an error rather than NULL if you try
this query on a queue that wasn't created with the ON_DEVICE and
DEVICE_DEFAULT flags. This isn't correct according to the CL spec but
limiting our testing to the supported case is still preferable to adding
an exception to the match files.
    @aarongreig @kbenzie
    aarongreig authored and kbenzie committed May 30, 2024
    Configuration menu
    Copy the full SHA
    41763be View commit details
    Browse the repository at this point in the history