Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[L0] Add support for multi-device kernel compilation #1135

Merged

Conversation

nrspruit
Copy link
Contributor

No description provided.

@nrspruit nrspruit force-pushed the multi_device_kernel_compilation_main branch 4 times, most recently from f12cccf to 44769d5 Compare November 29, 2023 00:30
@nrspruit nrspruit force-pushed the multi_device_kernel_compilation_main branch from 44769d5 to 14029ab Compare November 29, 2023 23:26
@nrspruit nrspruit force-pushed the multi_device_kernel_compilation_main branch from 14029ab to 12e59d4 Compare November 29, 2023 23:30
@nrspruit nrspruit force-pushed the multi_device_kernel_compilation_main branch from 12e59d4 to aed4e70 Compare November 30, 2023 01:32
@fabiomestre fabiomestre changed the base branch from adapters to main December 5, 2023 16:44
@fabiomestre
Copy link
Contributor

I have updated the target branch of this PR from the adapters branch to the main branch.
Development in UR is moving back to main. The adapters branch will soon be deleted.

@nrspruit
Copy link
Contributor Author

nrspruit commented Dec 5, 2023

I have updated the target branch of this PR from the adapters branch to the main branch. Development in UR is moving back to main. The adapters branch will soon be deleted.

Thank you! Much appreciated.

@nrspruit nrspruit force-pushed the multi_device_kernel_compilation_main branch from aed4e70 to 703316f Compare December 7, 2023 19:18
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92f44da) 15.57% compared to head (1b2cd5b) 15.58%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1135   +/-   ##
=======================================
  Coverage   15.57%   15.58%           
=======================================
  Files         233      233           
  Lines       32088    32088           
  Branches     3638     3638           
=======================================
+ Hits         4999     5000    +1     
  Misses      27038    27038           
+ Partials       51       50    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nrspruit nrspruit force-pushed the multi_device_kernel_compilation_main branch from 703316f to 715e118 Compare December 15, 2023 21:45
@nrspruit nrspruit force-pushed the multi_device_kernel_compilation_main branch 2 times, most recently from 20d1d20 to 0b41cc3 Compare December 18, 2023 21:20
@nrspruit nrspruit force-pushed the multi_device_kernel_compilation_main branch 3 times, most recently from a627be7 to 84c241d Compare January 17, 2024 02:47
@nrspruit nrspruit added the level-zero L0 adapter specific issues label Jan 17, 2024
@nrspruit nrspruit marked this pull request as ready for review January 17, 2024 03:19
@nrspruit nrspruit requested a review from a team as a code owner January 17, 2024 03:19
@nrspruit nrspruit force-pushed the multi_device_kernel_compilation_main branch from 84c241d to cd1670d Compare January 18, 2024 01:56
@nrspruit nrspruit force-pushed the multi_device_kernel_compilation_main branch from cd1670d to 1539e7f Compare January 18, 2024 02:05
@nrspruit nrspruit force-pushed the multi_device_kernel_compilation_main branch 2 times, most recently from b27b1ed to 865f29a Compare January 18, 2024 20:01
@nrspruit nrspruit added the v0.8.x Include in the v0.8.x release label Jan 19, 2024
Signed-off-by: Spruit, Neil R <neil.r.spruit@intel.com>
… size

- Decrement the program handle reference count & release the
  L0 resources if the refcnt == 0, but don't delete the program
  handle in the kernel teardown to avoid invalid memory access
  during program handle teardown.

Signed-off-by: Spruit, Neil R <neil.r.spruit@intel.com>
Signed-off-by: Spruit, Neil R <neil.r.spruit@intel.com>
@nrspruit nrspruit force-pushed the multi_device_kernel_compilation_main branch from 4c1df78 to 1b2cd5b Compare January 19, 2024 20:54
nrspruit added a commit to nrspruit/llvm that referenced this pull request Jan 19, 2024
sycl changes for oneapi-src/unified-runtime#1135

Enables multi device kernel compilation for level zero

Signed-off-by: Spruit, Neil R <neil.r.spruit@intel.com>
@nrspruit nrspruit added the ready to merge Added to PR's which are ready to merge label Jan 22, 2024
@nrspruit
Copy link
Contributor Author

Hello @kbenzie , please merge this to main and 0.8.x when you are able.

@kbenzie kbenzie merged commit 7c58060 into oneapi-src:main Jan 23, 2024
51 checks passed
@kbenzie
Copy link
Contributor

kbenzie commented Jan 23, 2024

Hello @kbenzie , please merge this to main and 0.8.x when you are able.

I missed this one. I'll go ahead and create v0.8.4 with just this since I don't see any other PR's with the v0.8.x label.

kbenzie added a commit that referenced this pull request Jan 23, 2024
…n_main

[L0] Add support for multi-device kernel compilation
@kbenzie kbenzie mentioned this pull request Jan 23, 2024
1 task
sommerlukas pushed a commit to intel/llvm that referenced this pull request Jan 23, 2024
pre-commit Pr for
oneapi-src/unified-runtime#1135

---------

Signed-off-by: Spruit, Neil R <neil.r.spruit@intel.com>
Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
kbenzie added a commit to kbenzie/llvm that referenced this pull request Jan 23, 2024
pre-commit Pr for
oneapi-src/unified-runtime#1135

---------

Signed-off-by: Spruit, Neil R <neil.r.spruit@intel.com>
Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
againull added a commit to againull/unified-runtime that referenced this pull request Jan 26, 2024
…_kernel_compilation_main"

This reverts commit 7c58060, reversing
changes made to 4f80080.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level-zero L0 adapter specific issues ready to merge Added to PR's which are ready to merge v0.8.x Include in the v0.8.x release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants