[UTIL] Make sure Windows.h doesn't define min #1258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define `NOMINMAX` before including Windows.h to fix the building in intel/llvm#12375.
callumfare
approved these changes
Jan 17, 2024
|
All targets should already have this problem fixed: |
This PI plugins aren't inheriting this build option. Saying that, might be possible to fix it in that CMake instead of here. |
|
Superceeded by #1260, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define
NOMINMAXbefore including Windows.h to fix the build in intel/llvm#12375.