Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor hip adapter to new logger #1359

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Refactor hip adapter to new logger #1359

merged 1 commit into from
Apr 10, 2024

Conversation

lplewa
Copy link
Contributor

@lplewa lplewa commented Feb 19, 2024

No description provided.

@lplewa
Copy link
Contributor Author

lplewa commented Feb 20, 2024

I created an octopus merge b45470f of all logs changes (#1359; #1347; #1345; #1342; #1032) and tested integration with intel/llvm repository

This was referenced Feb 20, 2024
Merged
Merged
Merged
Merged
@lplewa lplewa changed the title update hip adapter to new logger Refactor hip adapter to new logger Feb 20, 2024
@lplewa lplewa marked this pull request as ready for review February 20, 2024 11:25
@lplewa lplewa requested a review from a team as a code owner February 20, 2024 11:25
@lplewa lplewa requested a review from mmoadeli February 20, 2024 11:25
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.46%. Comparing base (78ef1ca) to head (db47fc0).
Report is 177 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1359      +/-   ##
==========================================
- Coverage   14.82%   12.46%   -2.36%     
==========================================
  Files         250      241       -9     
  Lines       36220    36146      -74     
  Branches     4094     4097       +3     
==========================================
- Hits         5369     4506     -863     
- Misses      30800    31636     +836     
+ Partials       51        4      -47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lplewa lplewa mentioned this pull request Feb 22, 2024
Merged
@fabiomestre fabiomestre mentioned this pull request Feb 28, 2024
Closed
@lplewa
Copy link
Contributor Author

lplewa commented Mar 14, 2024

@oneapi-src/unified-runtime-hip-write - please review - if you are ok with changes please label it as ready to merge

@hdelan
Copy link
Contributor

hdelan commented Mar 14, 2024

Could you rebase to re-run the CI? Some jobs failed last time round

hdelan
hdelan requested changes Mar 14, 2024
View reviewed changes
source/adapters/hip/common.cpp Outdated Show resolved Hide resolved
source/adapters/hip/adapter.cpp Outdated Show resolved Hide resolved
source/adapters/hip/adapter.cpp Show resolved Hide resolved
@lplewa
Refactor hip adapter to new logger
db47fc0 
This commit refactors the hip adapter to adopt the new logger
introduced in d9cd223 (Integrate logger with library, 2023-02-03).

Signed-off-by: Łukasz Plewa <lukasz.plewa@intel.com>
hdelan
hdelan approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@hdelan hdelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lplewa lplewa added the ready to merge Added to PR's which are ready to merge label Mar 25, 2024
@kbenzie kbenzie added the hip HIP adapter specific issues label Apr 3, 2024
@kbenzie kbenzie merged commit 08b3e8f into oneapi-src:main Apr 10, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdelan hdelan hdelan approved these changes

@mmoadeli mmoadeli Awaiting requested review from mmoadeli mmoadeli is a code owner automatically assigned from oneapi-src/unified-runtime-hip-write

Assignees
No one assigned
Labels
hip HIP adapter specific issues ready to merge Added to PR's which are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lplewa @codecov-commenter @hdelan @kbenzie