[test] Fix infinite loop when we run out of input

[ldrumm]

d6930c7 introduced Status.INPUT_END but didn't introduce the means to handle that eventuality. It looks like the intention might have been to exit with success if we've got to the end of input. However, if we run out of input and still have matches pending, I'm treating this as a failure.

Infinite loop reproducer:
_matchtmpfile.txt
input.txt

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.51%. Comparing base (78ef1ca) to head (c549757).
Report is 83 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1396      +/-   ##
==========================================
- Coverage   14.82%   12.51%   -2.31%     
==========================================
  Files         250      239      -11     
  Lines       36220    35942     -278     
  Branches     4094     4076      -18     
==========================================
- Hits         5369     4498     -871     
- Misses      30800    31440     +640     
+ Partials       51        4      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kbenzie]

Looks like the CUDA match file needs updated after this patch?

[ldrumm]

Looks like the CUDA match file needs updated after this patch?

Yeah. I'll see what I can do

[kswiecicki]

There might be a scenario where we get to the end of the input, and the remaining matches are marked with {{OPT}}. In that case we expect a success.

[kswiecicki]

Maybe something like this could work:

elif status == Status.INPUT_END and input_idx >= len(match_lines) + len(ignored_lines):
            print_incorrect_match(match_idx + 1, "", match_lines[match_idx]);
            print_content(input_lines, match_lines, ignored_lines)
            sys.exit(1)

[ldrumm]

Yeah, that's good. Just ran into the ignored lines problem. I'll add that

[ldrumm]

I went with a loop to consume remaining matches rather than just arithmetic because non-optional matches might still remain e.g.
matchfile:

{{OPT}} foo
bar
{{OPT}}baz

input:

foo

Thanks for the suggestion