-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for command-buffer kernel updates #1924
Add support for command-buffer kernel updates #1924
Conversation
bf49ae5
to
c06abd1
Compare
test/conformance/exp_command_buffer/update/kernel_handle_update.cpp
Outdated
Show resolved
Hide resolved
9997afa
to
f478846
Compare
5ddaec0
to
59e890c
Compare
7735328
to
52f534d
Compare
This PR should be ready for reviewing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Native CPU lgtm, thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cuda/hip lgtm
- Updates the specification to add support for command-buffer kernel handle updates. - Adds new UR tests for this feature. - Adds an implementation for the Cuda and Hip adapters. - Changes the UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_SUPPORT_EXP enum to a new UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_CAPABILITIES_EXP which uses a bitfield instead of a boolean. - Changes the spec for urCommandBufferUpdateKernelLaunchExp and ur_exp_command_buffer_update_kernel_launch_desc_t to make it more intuitive with less complicated errors codes: - Passing a non-nullptr local work-group will now always update the command to use that value. - Passing a nullptr local work-group will now always keep the current command behaviour (either generated by the implementation or user-defined). - Passing zero to newWorkDim is now an error.
52f534d
to
d944ff3
Compare
…15287) Updates the call to urCommandBufferAppendKernelLaunchExp to use the new UR parameters. Corresponding UR PR: oneapi-src/unified-runtime#1924 --------- Co-authored-by: Aaron Greig <aaron.greig@codeplay.com>
UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_SUPPORT_EXP
enum to a newUR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_CAPABILITIES_EXP
which uses a bitfield instead of a boolean.urCommandBufferUpdateKernelLaunchExp
andur_exp_command_buffer_update_kernel_launch_desc_t
to make it more intuitive with less complicated errors codes:intel/llvm PR: intel/llvm#15287