[L0] Refactor to remove default constructor inits #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Sep 5, 2024
nrspruit
commented
- Remove all the default constructor inits to address error prone code changes and force setting of options and flags individually.
github-actions
bot
added
images
nrspruit
force-pushed
the
refactor_l0_default_init
branch
from
97dd83d
to
685973d
Compare
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Sep 5, 2024
-pre-commit PR for oneapi-src/unified-runtime#2063 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
ProGTX
approved these changes
Sep 6, 2024
cppchedy
approved these changes
Sep 6, 2024
nrspruit
force-pushed
the
refactor_l0_default_init
branch
from
685973d
to
9b43a4c
Compare
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Sep 10, 2024
-pre-commit PR for oneapi-src/unified-runtime#2063 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Sep 10, 2024
-pre-commit PR for oneapi-src/unified-runtime#2063 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
fabiomestre
approved these changes
Sep 16, 2024
- Remove all the default constructor inits to address error prone code changes and force setting of options and flags individually. Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
force-pushed
the
refactor_l0_default_init
branch
from
9b43a4c
to
4854c2f
Compare
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Oct 2, 2024
-pre-commit PR for oneapi-src/unified-runtime#2063 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
|
this is missing a review from @oneapi-src/unified-runtime-level-zero-write |
pbalcer
approved these changes
Oct 16, 2024
aarongreig
pushed a commit
to nrspruit/llvm
that referenced
this pull request
Oct 17, 2024
-pre-commit PR for oneapi-src/unified-runtime#2063 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
sarnex
pushed a commit
to intel/llvm
that referenced
this pull request
Oct 17, 2024
-pre-commit PR for oneapi-src/unified-runtime#2063 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.