Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CUDA][HIP] Fix exceptions throwing from adapter #2154

Merged
merged 1 commit into from
Oct 1, 2024
Merged

[CUDA][HIP] Fix exceptions throwing from adapter #2154

merged 1 commit into from
Oct 1, 2024

Conversation

npmiller
Copy link
Contributor

@npmiller npmiller commented Oct 1, 2024

UR_CHECK_ERROR will throw an exception if an error is found, so it should only be used within a try/catch block, otherwise the exception may leak out of the adapter.

@npmiller npmiller requested a review from a team as a code owner October 1, 2024 10:34
@github-actions github-actions bot added cuda CUDA adapter specific issues hip HIP adapter specific issues command-buffer Command Buffer feature addition/changes/specification labels Oct 1, 2024
@npmiller
[CUDA][HIP] Fix exceptions throwing from adapter
04ffc90 
`UR_CHECK_ERROR` will throw an exception if an error is found, so it
should only be used within a try/catch block, otherwise the exception
may leak out of the adapter.
@npmiller npmiller mentioned this pull request Oct 1, 2024
Closed
@kbenzie
Copy link
Contributor

kbenzie commented Oct 1, 2024

Looks like a enum name has changed https://github.com/oneapi-src/unified-runtime/actions/runs/11123869065/job/30909847194?pr=2154

../sycl-repo/sycl/source/detail/device_impl.cpp:710:22: error: ‘UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_SUPPORT_EXP’ was not declared in this scope; did you mean ‘UR_DEVICE_INFO_COMMAND_BUFFER_SUPPORT_EXP’?
  710 |             MDevice, UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_SUPPORT_EXP,
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                      UR_DEVICE_INFO_COMMAND_BUFFER_SUPPORT_EXP

@EwanC
Copy link
Contributor

EwanC commented Oct 1, 2024

Looks like a enum name has changed https://github.com/oneapi-src/unified-runtime/actions/runs/11123869065/job/30909847194?pr=2154

../sycl-repo/sycl/source/detail/device_impl.cpp:710:22: error: ‘UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_SUPPORT_EXP’ was not declared in this scope; did you mean ‘UR_DEVICE_INFO_COMMAND_BUFFER_SUPPORT_EXP’?
  710 |             MDevice, UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_SUPPORT_EXP,
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                      UR_DEVICE_INFO_COMMAND_BUFFER_SUPPORT_EXP

This will be resolved when intel/llvm#15287 merges

@kbenzie kbenzie added the ready to merge Added to PR's which are ready to merge label Oct 1, 2024
@kbenzie kbenzie mentioned this pull request Oct 1, 2024
Merged
4 tasks
@aarongreig
Copy link
Contributor

bump PR for reference intel/llvm#15568

@aarongreig aarongreig merged commit 0247d09 into oneapi-src:main Oct 1, 2024
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbenzie kbenzie kbenzie approved these changes

@EwanC EwanC EwanC approved these changes

Assignees
No one assigned
Labels
command-buffer Command Buffer feature addition/changes/specification cuda CUDA adapter specific issues hip HIP adapter specific issues ready to merge Added to PR's which are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@npmiller @kbenzie @EwanC @aarongreig