Add test for urEnqueueUSMPrefetch #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongreig
reviewed
Mar 1, 2023
veselypeta
approved these changes
Mar 2, 2023
| urEnqueueUSMPrefetch(queue, ptr, sizeof(int), | ||
| UR_USM_MIGRATION_FLAG_DEFAULT, 0, &validEvent, | ||
| nullptr)); | ||
| } |
There was a problem hiding this comment.
Probably not required for this PR but maybe we can have a test which uses the pEventWaitlist?
There was a problem hiding this comment.
I added a new test for this. I'm not sure if this would be the best way to test this behaviour. Please let me know if you know of a better way.
fabiomestre
force-pushed
the
enqueueUSMPrefetch
branch
from
45e08b8
to
4935e71
Compare
aarongreig
approved these changes
Mar 2, 2023
veselypeta
reviewed
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #245