[Bindless] Struct for unique addressing modes per dimension #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veselypeta
approved these changes
Sep 15, 2023
kbenzie
approved these changes
Sep 15, 2023
veselypeta
reviewed
Sep 15, 2023
scripts/core/exp-bindless-images.yml
Outdated
| base: $x_base_properties_t | ||
| members: | ||
| - type: $x_sampler_addressing_mode_t | ||
| name: addrModes[3] |
There was a problem hiding this comment.
Unfortunatelly this won't work with the current generator. I think the simplest solution would be to just have three named fields for the addressing mode values.
There was a problem hiding this comment.
Is this something that may change in the future? Ideally we'd like to use an array.
There was a problem hiding this comment.
I've created #869 to add this support.
There was a problem hiding this comment.
Great, thanks! We'll keep an eye on this but will use the separate variables as a temporary solution.
veselypeta
reviewed
Sep 15, 2023
Seanst98
force-pushed
the
sean/addr-mode-per-dimension
branch
from
5e3334b
to
5640ea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds a struct allowing for unique addressing modes per dimension