[OpenCL] Add version check for urProgramSetSpecializationConstants #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongreig
approved these changes
Oct 18, 2023
martygrant
force-pushed
the
martin/versionCheckSpecializationConstants
branch
from
dfdadef
to
1a5146f
Compare
martygrant
changed the title
martygrant
force-pushed
the
martin/versionCheckSpecializationConstants
branch
from
1a5146f
to
09ee4c0
Compare
martygrant
force-pushed
the
martin/versionCheckSpecializationConstants
branch
from
09ee4c0
to
bd362a1
Compare
kbenzie
approved these changes
Oct 31, 2023
martygrant
force-pushed
the
martin/versionCheckSpecializationConstants
branch
from
bd362a1
to
f2a365c
Compare
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a version check to only look up the extension function pointer for urProgramSetSpecializationConstants if the platform or any attached device OpenCL version is < 2.2. Also fixes minor build error with missing namespace in enqueue.cpp.
intel-llvm PR - intel/llvm#11720