Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added PR template #11

Merged
merged 2 commits into from
Oct 27, 2022
Merged

feat: added PR template #11

merged 2 commits into from
Oct 27, 2022

Conversation

dustytrinkets
Copy link
Contributor

@dustytrinkets dustytrinkets commented Oct 26, 2022

What’s the focus of this PR

This PR adds this awesome PR template. Feel free to suggest modifications for it

How to review this PR

With lots of love

Before submitting this PR, I made sure:

  • The code builds clean without any errors or warnings
  • I'm using our guidelines
  • I've added unit tests if feasible

Copy link
Collaborator

@ardguezsoc ardguezsoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we dont need this because @inigomarquinez wanted to prepare some templates for the organization One Beyond. So once it is done we would inherit that from there and use them by default because we are not using once. But im not sure ❓ ❓

@dustytrinkets
Copy link
Contributor Author

I wasn't aware of this, @inigomarquinez should we wait for the general one to be included?

Copy link
Member

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about the location of the file

pull_request_template.md Outdated Show resolved Hide resolved
Copy link
Member

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll add one single template in the new organization. But as we don't know yet when that will be ready, we can proceed with this one and replace it with the new one once we migrate to the new organization. And that way you have this PR for the Hacktoberfest ;)

@inigomarquinez inigomarquinez self-requested a review October 27, 2022 11:03
@dustytrinkets dustytrinkets merged commit b8e5d49 into main Oct 27, 2022
@dustytrinkets dustytrinkets deleted the feat-323-add-pr-template branch October 27, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants