Monorepo structure #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 28, 2022 19:45
inigomarquinez
requested review from
neodmy,
dustytrinkets and
ardguezsoc
as code owners
neodmy
reviewed
Nov 8, 2022
dustytrinkets
approved these changes
Nov 8, 2022
ardguezsoc
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What’s the focus of this PR
This PR prepares the repository to store both CuckooJS CLI and CuckooJS Schematics, using npm workspaces.
It also fixes some minor details and adds some features both to CLI and Schematics packages.
Finally, it adds GitHub actions to publish the cli and schematics to the np public registry when a new release is published (see
.github/workflowsfolder)How to review this PR
npm link --workspacesfrom the root folder and then try to use the CLI (cuckoo new app) or try to run a schematic (schematics @guidesmiths/cuckoojs-schematics:gitignore --directory=.).Before submitting this PR, I made sure: