Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/move deps to dev deps #23

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Fix/move deps to dev deps #23

merged 2 commits into from
Nov 21, 2022

Conversation

w3dani
Copy link
Contributor

@w3dani w3dani commented Nov 18, 2022

What’s the focus of this PR

This PR move some dependencies that are devDependencies to devDependencies

How to review this PR

Just check what I'm saying is true -> https://www.typescriptlang.org/download

Before submitting this PR, I made sure:

  • [] The code builds clean without any errors or warnings (test doesn't work yet)
  • I'm using our guidelines
  • I've added unit tests if feasible

Copy link
Contributor

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We tried this before but we had to move it to dependencies because the GitHub action was failing, but we found the error. So now it should work smoothly :)

@inigomarquinez inigomarquinez merged commit ee3f9d3 into main Nov 21, 2022
@inigomarquinez inigomarquinez deleted the fix/move-deps-to-dev-deps branch November 21, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants