Feat/lambda eslint config #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inigomarquinez
approved these changes
Dec 19, 2022
neodmy
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What’s the focus of this PR
This PR provides ESlint initialization to lambda quickstart. I focused in lambda quickstart but it could be reused for microservice one, but I didn't changed it because maybe nestJs has it's own preferences for linting.
Initialy airbnb is configured, but the idea is to provide more options in the future to make it more dynamic and allow other configurations.
btw, I've changed the classes approach to function approach (more closer to the systemic way)
Note: The way the project is built from cli can be improved (a lot of commands chained, and not in a way to scale properly, but there is another issue that will cover this refactor)
How to review this PR
Launch the quickstart and review it.
Before submitting this PR, I made sure: