Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/husky schematic #42

Merged
merged 12 commits into from
Apr 13, 2023
Merged

Feat/husky schematic #42

merged 12 commits into from
Apr 13, 2023

Conversation

neodmy
Copy link
Contributor

@neodmy neodmy commented Dec 23, 2022

What’s the focus of this PR

Schematic to add Husky to projects. This is intended to be independent of other schematics and the CLI.

How to review this PR

We have added a utility to manage the package.json that is based on @nestjs/schematics/dist/utils/dependencies.utils. The schematic uses that utility to manipulate the package.json as a tree using jsonc-parser (link

Before submitting this PR, I made sure:

  • The code builds clean without any errors or warnings
  • I'm using our guidelines
  • I've added unit tests if feasible

@neodmy neodmy self-assigned this Dec 23, 2022
Copy link
Member

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Some comments added :)

@neodmy neodmy marked this pull request as ready for review January 2, 2023 09:51
@inigomarquinez inigomarquinez marked this pull request as draft January 18, 2023 09:15
@neodmy neodmy marked this pull request as ready for review April 13, 2023 06:27
@neodmy neodmy requested a review from inigomarquinez April 13, 2023 07:45
Copy link
Member

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@inigomarquinez inigomarquinez merged commit 0c64480 into main Apr 13, 2023
@inigomarquinez inigomarquinez deleted the feat/husky-schematic branch April 13, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants