Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use lerna to manage monorepo #64

Merged
merged 4 commits into from
Apr 27, 2023
Merged

refactor: use lerna to manage monorepo #64

merged 4 commits into from
Apr 27, 2023

Conversation

neodmy
Copy link
Contributor

@neodmy neodmy commented Apr 17, 2023

Use Lerna to manage packages in this monorepo

Description

Add Lerna to manage package releases. For the moment, I propose to manage the versions manually.

Related Issue

#63

Motivation and Context

We want to release our 2 current packages in a more convenient way, meaning releasing new versions more automatically. There are options to automatize this, but the previous step should be using a tool that manages monorepos. I've thought of Lerna, as it's got some commands to do that. Next steps might be to incorporate a tool to analyze the commit message syntax to detect the right semver automatically. But for the moment I suggest we manage the versions ourselves.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neodmy neodmy requested a review from UlisesGascon April 17, 2023 15:53
@neodmy neodmy marked this pull request as ready for review April 26, 2023 07:21
@neodmy neodmy self-assigned this Apr 26, 2023
@neodmy neodmy requested a review from inigomarquinez April 26, 2023 07:22
Copy link
Contributor

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neodmy neodmy merged commit 9922cb7 into main Apr 27, 2023
@neodmy neodmy deleted the refactor/use-lerna branch April 27, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants