chore: bump lerna and fix lerna.json #76
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've been experiencing an issue when publishing packages to npm through the GitHub workflow. Although it seems to manage the publication of the packages just fine (they get actually published to Npm), it throws an error after that. I think the problem lies on the root
package.json
configuration. Apparently, the missingprivate: true
property makes Lerna try to publish the root package, which is bad. After checking this tutorial and the repo, that's the only plausible explanation I found. Actually, the test project I did months ago to try Lerna already included it. So I must have missed it when setting Lerna up on this project 😞 .Based on the tutorial and example repo, I've also added one action to set up Node and install dependencies that is used across the three new workflows:
ci.yml
-> to test, build and lint files. Test and lint jobs are commented out. Some tests don't pass and the linter throws errors due to misconfiguration probably.version.yml
-> this will generate a commit to bump the version of all packages. The triggerworkflow_dispatch
makes it manual, so we can always be certain of the version we want to bump to.publish.yml
-> triggers on a new tag. So it will trigger immediately after we successfully version our packages.Related Issue
#77
Motivation and Context
Fix the erroneous GitHub workflow and provide a better, safer way to version and publish packages
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: