Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump lerna and fix lerna.json #76

Merged
merged 5 commits into from
Nov 3, 2023
Merged

chore: bump lerna and fix lerna.json #76

merged 5 commits into from
Nov 3, 2023

Conversation

neodmy
Copy link
Contributor

@neodmy neodmy commented Nov 2, 2023

Description

We've been experiencing an issue when publishing packages to npm through the GitHub workflow. Although it seems to manage the publication of the packages just fine (they get actually published to Npm), it throws an error after that. I think the problem lies on the root package.json configuration. Apparently, the missing private: true property makes Lerna try to publish the root package, which is bad. After checking this tutorial and the repo, that's the only plausible explanation I found. Actually, the test project I did months ago to try Lerna already included it. So I must have missed it when setting Lerna up on this project 😞 .

Based on the tutorial and example repo, I've also added one action to set up Node and install dependencies that is used across the three new workflows:

  • ci.yml -> to test, build and lint files. Test and lint jobs are commented out. Some tests don't pass and the linter throws errors due to misconfiguration probably.
  • version.yml -> this will generate a commit to bump the version of all packages. The trigger workflow_dispatch makes it manual, so we can always be certain of the version we want to bump to.
  • publish.yml -> triggers on a new tag. So it will trigger immediately after we successfully version our packages.

Related Issue

#77

Motivation and Context

Fix the erroneous GitHub workflow and provide a better, safer way to version and publish packages

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
lerna 6.6.2...7.4.2 network +48/-106 92.4 MB jameshenry

@neodmy neodmy requested a review from inigomarquinez November 2, 2023 19:45
Copy link
Member

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A-MA-ZING! 🤩

@neodmy neodmy merged commit 511e457 into main Nov 3, 2023
1 check passed
@neodmy neodmy deleted the chore/fix-lerna branch November 3, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants