Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add node annotation #107

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix: add node annotation #107

merged 1 commit into from
Nov 7, 2023

Conversation

neodmy
Copy link
Contributor

@neodmy neodmy commented Nov 7, 2023

Description

When executing the bin entry point, it throws an error due to the missing node executable annotation

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@inigomarquinez
Copy link
Member

I didn't know we had to add that in the entry point of a CLI!

@neodmy neodmy merged commit e19ae4b into main Nov 7, 2023
4 checks passed
@neodmy neodmy deleted the fix/amend-entry-point branch November 7, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants