Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make regex function compatible with node versions prior to v14 #48

Merged
merged 3 commits into from
May 9, 2022

Conversation

neodmy
Copy link
Contributor

@neodmy neodmy commented May 4, 2022

Main changes

  • 🔄 (refactor): remove optional chaining operator for node backwards compatibility

Context

@neodmy neodmy self-assigned this May 4, 2022
dustytrinkets
dustytrinkets previously approved these changes May 4, 2022
ardguezsoc
ardguezsoc previously approved these changes May 4, 2022
inigomarquinez
inigomarquinez previously approved these changes May 4, 2022
Copy link
Contributor

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks @neodmy !

@neodmy neodmy dismissed stale reviews from inigomarquinez, ardguezsoc, and dustytrinkets via c3e24a6 May 9, 2022 07:50
@neodmy neodmy merged commit dcaa8f8 into main May 9, 2022
@neodmy neodmy deleted the refactor/pre-node14-compatibility branch May 9, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants