Allow more features from API endpoint #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 9, 2024 11:04
Added two features which are allowed by the Notion endpoint API and can be useful to further customize the export: - recursive, allows to export one block and alla the block children - no-files, to avoid downloading files like pdf or images (as it is optional from the UI) Also, addeda function `getMdFiles` to dump the files in a folder (this is useful if we want to use a function from langchain, for example, to load all files in a folder).
UlisesGascon
approved these changes
Feb 15, 2024
Comment on lines
+49
to
+50
| timeZone: "Europe/Zurich", | ||
| locale: "en", |
There was a problem hiding this comment.
Maybe we can allow in the future that these values are configurable? 🤔
There was a problem hiding this comment.
yep, I'll try to configure it in the next PR, event if it is mixed with the package qualified name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to get exported a whole bunch of blocks children along with the parent to embed the documentation in a vector store. So, starting off you work we implemented chance to perform:
Also, added a new method to unzip all exported files into a folder (for us that is useful to use LangChain's NotionLoader