Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file validators to handle mp3 and rtf formats #123

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

JRD-OneBeyond
Copy link
Contributor

Add mp3 and rtf support
Handle case where very small files causes an exception to be thrown on validation

Related Issue

#122

Motivation and Context

Expanded support for file validation

How Has This Been Tested?

This was tested on a dev laptop
obelisk was built locally
a working project was updated to use the local version of Obelisk as a project dependency
The code was stepped through and tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

Handle case where very small files causes an exception to be thrown on validation
@andriikaplanovskyi andriikaplanovskyi merged commit 27f8725 into main Nov 8, 2023
3 checks passed
@andriikaplanovskyi andriikaplanovskyi deleted the FileValidators/JRD-HandleMp3AndRtf branch November 8, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants