Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 180/loading #181

Merged
merged 18 commits into from
Jan 31, 2024
Merged

Fix 180/loading #181

merged 18 commits into from
Jan 31, 2024

Conversation

inigomarquinez
Copy link
Contributor

@inigomarquinez inigomarquinez commented Jan 30, 2024

Description

  • fix: disable submit button when form is being submitted
  • fix: prevent re-submitting the form while it's being submitted
  • fix: remove support for node < 16 and npm < 8
  • feat: add devtools when in DEV mode
  • chore: remove commented code in example app
  • refactor: move some styles to separate files
  • chore: simulate long submission in the example
  • ci: add ci workflow
  • ci: add scorecard workflows
  • feat: upgrade to node v20
  • chore: update dependencies
  • fix: linter errors and warnings
  • ci: rename namespace from guidesmiths to onebeyond

Related Issue

Closes #180

Motivation and Context

#180

How Has This Been Tested?

Running the example locally and also running the existing tests

Screenshots (if appropriate):

react-form-builder.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@inigomarquinez inigomarquinez added the enhancement New feature or request label Jan 30, 2024
@inigomarquinez inigomarquinez self-assigned this Jan 30, 2024
Copy link

socket-security bot commented Jan 30, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/core@7.23.9 environment, filesystem, unsafe Transitive: shell +51 10.7 MB nicolo-ribaudo
npm/@babel/eslint-parser@7.23.9 unsafe Transitive: environment, eval, filesystem, shell +149 22.8 MB nicolo-ribaudo
npm/@commitlint/cli@18.6.0 Transitive: environment, filesystem, shell, unsafe +165 76.6 MB bycedric, escapedcat, marionebl, ...1 more
npm/@commitlint/config-conventional@18.6.0 Transitive: filesystem +5 45.1 kB bycedric, escapedcat, marionebl, ...1 more
npm/@hookform/devtools@4.3.1 environment Transitive: filesystem, unsafe +68 14.5 MB bluebill1049
npm/@storybook/addon-actions@7.6.11 Transitive: environment +9 3.68 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/addon-essentials@7.6.11 Transitive: environment, eval, filesystem, network, shell, unsafe +395 271 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/addon-links@7.6.11 Transitive: environment +7 935 kB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@storybook/react@7.6.11 Transitive: environment, eval, filesystem, network, shell, unsafe +202 308 MB hypnosphi, igor-dv, jreinhold, ...5 more
npm/@testing-library/react@14.2.0 Transitive: environment, eval +80 17.3 MB brrianalexis, cmckinstry, dfcook, ...12 more
npm/eslint-config-prettier@9.1.0 Transitive: environment, eval, filesystem, shell, unsafe +95 11.9 MB lydell
npm/eslint-config-standard-react@13.0.0 Transitive: environment, eval, filesystem, shell, unsafe +187 17.1 MB linusu
npm/eslint-config-standard@17.1.0 Transitive: environment, eval, filesystem, shell, unsafe +182 18.2 MB voxpelli
npm/eslint-plugin-import@2.29.1 filesystem, unsafe Transitive: environment, eval, shell +172 17.2 MB ljharb
npm/eslint-plugin-n@16.6.2 filesystem Transitive: environment, eval, shell, unsafe +108 13 MB weiran.zsd
npm/eslint-plugin-prettier@5.1.3 Transitive: environment, eval, filesystem, shell, unsafe +105 20.8 MB jounqin
npm/eslint-plugin-promise@6.1.1 Transitive: environment, eval, filesystem, shell, unsafe +95 12 MB eslint-community-bot
npm/eslint@8.56.0 environment, filesystem Transitive: eval, shell, unsafe +94 11.9 MB eslintbot
npm/husky@9.0.7 environment, filesystem, shell 0 3.66 kB typicode
npm/joi@17.12.1 None +5 669 kB marsup
npm/npm-check-updates@16.14.14 environment, filesystem Transitive: network, shell, unsafe +277 12 MB raine
npm/postcss@8.4.33 environment, filesystem +3 227 kB ai
npm/prettier@3.2.4 environment, filesystem, unsafe 0 8.38 MB prettier-bot
npm/react-datepicker@4.25.0 Transitive: environment +17 14.2 MB mrusschen
npm/react-hook-form@7.49.3 network Transitive: environment +3 1.22 MB bluebill1049
npm/react-phone-number-input@3.3.9 Transitive: environment +12 29.5 MB catamphetamine

🚮 Removed packages: npm/@babel/core@7.23.3, npm/@commitlint/cli@18.4.3, npm/@commitlint/config-conventional@18.4.3, npm/@storybook/addon-actions@7.5.3, npm/@storybook/addon-essentials@7.5.3, npm/@storybook/addon-links@7.5.3, npm/@storybook/react@7.5.3, npm/@testing-library/react@14.1.2, npm/babel-eslint@10.1.0, npm/eslint-config-prettier@6.15.0, npm/eslint-config-standard-react@9.2.0, npm/eslint-config-standard@14.1.1, npm/eslint-plugin-import@2.29.0, npm/eslint-plugin-prettier@3.4.1, npm/eslint-plugin-promise@4.3.1, npm/eslint@6.8.0, npm/husky@8.0.3, npm/joi@17.11.0, npm/npm-check-updates@16.14.11, npm/npm@8.19.4, npm/postcss@8.4.31, npm/prettier@2.8.8, npm/react-datepicker@4.23.0, npm/react-hook-form@7.48.2, npm/react-phone-number-input@3.3.7

View full report↗︎

@inigomarquinez inigomarquinez marked this pull request as ready for review January 31, 2024 09:07
Copy link

@habondavid habondavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.nvmrc Outdated Show resolved Hide resolved
Copy link
Contributor

@pabloelisseo pabloelisseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@inigomarquinez inigomarquinez merged commit f19887a into main Jan 31, 2024
5 checks passed
@inigomarquinez inigomarquinez deleted the fix-180/loading branch January 31, 2024 10:19
@inigomarquinez
Copy link
Contributor Author

@all-contributors please add @habondavid for bug, review

Copy link
Contributor

@inigomarquinez

I've put up a pull request to add @habondavid! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: active form elements during loading
3 participants