Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add international option to Phone #206

Merged

Conversation

matyasjay
Copy link
Member

@matyasjay matyasjay commented Mar 1, 2024

Description

Add international Phone question option to force display country code in Phone input

Related Issue

Closes #204

Motivation and Context

How Has This Been Tested?

Unit test case to check if country prefix is appended to Phone input by default when international flag provided.

Screenshots (if appropriate):

src

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

inigomarquinez
inigomarquinez previously approved these changes Mar 1, 2024
Copy link
Member

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matyasjay matyasjay requested a review from inigomarquinez March 1, 2024 13:34
Copy link

socket-security bot commented Mar 1, 2024

Copy link

socket-security bot commented Mar 1, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/core-js-pure@3.36.0, npm/core-js@3.36.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@inigomarquinez
Copy link
Member

@SocketSecurity ignore npm/core-js@3.36.0
@SocketSecurity ignore npm/core-js-pure@3.36.0

@inigomarquinez inigomarquinez merged commit c490d2c into onebeyond:main Mar 1, 2024
5 checks passed
@inigomarquinez
Copy link
Member

@all-contributors please add @matyasjay for code

Copy link
Contributor

@inigomarquinez

I've put up a pull request to add @matyasjay! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE: display country codes beside the flag in Phone input
2 participants