Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export #208

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Fix export #208

merged 2 commits into from
Mar 4, 2024

Conversation

inigomarquinez
Copy link
Member

Description

The latest versions of the library were failing when importing them in a react app. This PR tries to fix that import problem.

One of the source problems was dynamically importing the countries' translations. Now the library comes with 4 default languages, but the user can import the translations library and configure more translations on their own.

Motivation and Context

Fix the error that prevents the latest versions of the ibrary from being used.

How Has This Been Tested?

Importing the library in a vite app and checking that it works.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@inigomarquinez inigomarquinez requested a review from matyasjay March 4, 2024 12:23
@inigomarquinez inigomarquinez self-assigned this Mar 4, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/npm-check-updates@16.14.15 environment, filesystem Transitive: network, shell, unsafe +299 16.4 MB raine
npm/react-router-dom@6.22.2 environment Transitive: network +2 4.03 MB mjackson

🚮 Removed packages: npm/@storybook/react@7.6.17, npm/@testing-library/jest-dom@5.17.0, npm/@testing-library/react@14.2.1, npm/countries-list@3.0.6, npm/cross-env@7.0.3

View full report↗︎

Copy link
Member

@matyasjay matyasjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising 🤞🏻 LGTM
Thank you!

@inigomarquinez inigomarquinez merged commit f5cc39e into main Mar 4, 2024
5 checks passed
@inigomarquinez inigomarquinez deleted the fix-export branch March 4, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants