Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript definitions #10

Merged
merged 2 commits into from
May 9, 2022
Merged

typescript definitions #10

merged 2 commits into from
May 9, 2022

Conversation

teunmooij
Copy link
Contributor

In v3.3.10 typescript definitions were added to Systemic. This PR is intended to also add definitions the Systemic express components.

Copy link
Collaborator

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Member

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@teunmooij
Copy link
Contributor Author

@UlisesGascon , @inigomarquinez Thanks for the review. If you agree with the changes, can you please merge them? I'm not authorized to do that.

@inigomarquinez inigomarquinez merged commit be3e9f5 into onebeyond:master May 9, 2022
@inigomarquinez
Copy link
Member

Hi @teunmooij !

I've just merged it. However, I need to make sure with my colleagues how to deploy a new version of the library. I'll keep you posted.

Thanks for the PR.

@inigomarquinez
Copy link
Member

Hi @teunmooij !

We've finally published v1.1.2 in npm with support for TS. Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants