Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add linter on pre-commit hook #16

Merged
merged 1 commit into from
Oct 25, 2022
Merged

ci: add linter on pre-commit hook #16

merged 1 commit into from
Oct 25, 2022

Conversation

totegsito
Copy link
Contributor

Main changes

  • ☁️ (ci): Add linter on pre-commit hook

@totegsito totegsito self-assigned this Oct 12, 2022
inigomarquinez
inigomarquinez reviewed Oct 17, 2022
View reviewed changes
Copy link
Member

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @totegsito !

I've added a small suggestion just in case you find it useful

.husky/pre-commit Show resolved Hide resolved
@inigomarquinez inigomarquinez self-requested a review October 25, 2022 13:09
inigomarquinez
inigomarquinez approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Betisman
Betisman approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@Betisman Betisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this

@inigomarquinez inigomarquinez merged commit 66e20e4 into onebeyond:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inigomarquinez inigomarquinez inigomarquinez approved these changes

@Betisman Betisman Betisman approved these changes

Assignees

@totegsito totegsito

Labels
enhancement hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@totegsito @Betisman @inigomarquinez