Allow request timeout modification in server #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change we want to make the request timeout of the server configurable. This is needed because server request timeout has changed from Node.js v18. Now it is set to 300000 milliseconds (5 minutes) by default. See docs: https://fek.io/blog/what-is-new-in-node-js-18/. Our current use case is that we have an upload asset endpoint that takes some time to upload a file, so with this default timeout the request was failing with a "Request timeout" error. That's why we need to customise this timeout value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes
Additional info
With this change we want to make the request timeout of the server configurable. This is needed because server request timeout has changed from Node.js v18. Now it is set to 300000 milliseconds (5 minutes) by default. See docs.
Our current use case is that we have an upload asset endpoint that takes some time to upload a file, so with this default timeout the request was failing with a "Request timeout" error with big files. That's why we need to customise this timeout value.
This value can be configurable in config.js