Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems to break with Ember 2.4.x (LTS release) #64

Closed
stonetwig opened this issue Mar 2, 2016 · 5 comments
Closed

Seems to break with Ember 2.4.x (LTS release) #64

stonetwig opened this issue Mar 2, 2016 · 5 comments
Assignees
Labels

Comments

@stonetwig
Copy link

Hey,

awesome plugin and we have tremendous use of it.
We have noticed that the data for the table doesn't auto-update with the ember model.

When the promise resolves, no data is ever shown in the table. Unsure on why this happens. But it works with Ember 2.3 and as soon as you make the jump to 2.4 it breaks.

Best wishes,
Markus

@onechiporenko
Copy link
Owner

Hi, Markus.
Thanks for response. Yes, such problem exists (I see it on the Travis CI).
Currently working on it, but can't give any estimates.

@onechiporenko onechiporenko self-assigned this Mar 2, 2016
@stonetwig
Copy link
Author

No worries and you shouldn't have to give any estimates, it's open source and I would gladly help if I knew how. Unfortunately at this time I cannot dig into a new project.

@onechiporenko
Copy link
Owner

@stonetwig, @nicozimmermann94, @rkuzsma, could you test latest code from repo please? I've added fix to correctly init table data. As @rkuzsma mentioned in the #70 (comment) - content is correctly updated when some sorting is done (table-header cell is clicked). I can't understand why exactly it happens. I tried to investigate computed.sort, but I've found only one thing (described in the emberjs/ember.js#13037).
So, what I've done. Until now table should always be sorted initially. If user didn't provide column to sort, table'll be sorted by the first column. It's kind of restriction, but I can't find another way.
If you find any other related bugs fill free to ask here or open another issues. Thanks

@rkuzsma
Copy link

rkuzsma commented Mar 21, 2016

I confirmed the table is loading properly with Ember 2.4.1 in the latest code from the repo today. Thanks @onechiporenko !

@stonetwig
Copy link
Author

Hello,

I just also want to confirm that this works with the latest version of Ember!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants