fix: proper of wait and dependsOn in flux ks and hr
#771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Devin Buhl <devin@buhl.casa>
github-actions
bot
added
area/github
Signed-off-by: Devin Buhl <devin@buhl.casa>
Signed-off-by: Devin Buhl <devin@buhl.casa>
onedr0p
changed the title
wait and dependsOn in flux ks and hr
onedr0p
changed the title
wait and dependsOn in flux ks and hrwait and dependsOn in flux ks and hr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan here is you only need to
wait: trueon flux ks that have child flux ks deps.The underlying problem is that if you push a bad helmrelease and wait is true on the flux ks that manages it, flux will not retry until the timeout on the flux ks.
With
wait: false, the helm controller will be the one alerting the problem and pushing a fix flux will apply the changes quicker instead of waiting for the flux ks to timeout.tl;dr: Use flux ks deps on flux ks that actually need to depend on other flux ks, use flux hr deps on flux hrs that need to depend on other flux hrs