Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (external-dns): test out unifi api key #8629

Merged
merged 2 commits into from
Jan 10, 2025
Merged

feat (external-dns): test out unifi api key #8629

merged 2 commits into from
Jan 10, 2025

Conversation

onedr0p
Copy link
Owner

@onedr0p onedr0p commented Jan 10, 2025

No description provided.

@bot-ross bot-ross bot added area/kubernetes Changes made in the kubernetes directory cluster/main labels Jan 10, 2025
@bot-ross
Copy link
Contributor

bot-ross bot commented Jan 10, 2025

--- kubernetes/main/apps/network/external-dns/unifi Kustomization: flux-system/external-dns-unifi ExternalSecret: network/external-dns-unifi

+++ kubernetes/main/apps/network/external-dns/unifi Kustomization: flux-system/external-dns-unifi ExternalSecret: network/external-dns-unifi

@@ -16,10 +16,9 @@

     kind: ClusterSecretStore
     name: onepassword-connect
   target:
     name: external-dns-unifi-secret
     template:
       data:
-        EXTERNAL_DNS_UNIFI_PASS: '{{ .EXTERNAL_DNS_UNIFI_PASS }}'
-        EXTERNAL_DNS_UNIFI_USER: '{{ .EXTERNAL_DNS_UNIFI_USER }}'
+        EXTERNAL_DNS_UNIFI_API_KEY: '{{ .EXTERNAL_DNS_UNIFI_API_KEY }}'
       engineVersion: v2
 
--- kubernetes/main/apps/network/external-dns/unifi Kustomization: flux-system/external-dns-unifi HelmRelease: network/external-dns-unifi

+++ kubernetes/main/apps/network/external-dns/unifi Kustomization: flux-system/external-dns-unifi HelmRelease: network/external-dns-unifi

@@ -38,25 +38,20 @@

     provider:
       name: webhook
       webhook:
         env:
         - name: UNIFI_HOST
           value: https://192.168.1.1
-        - name: UNIFI_USER
+        - name: UNIFI_API_KEY
           valueFrom:
             secretKeyRef:
-              key: EXTERNAL_DNS_UNIFI_USER
-              name: external-dns-unifi-secret
-        - name: UNIFI_PASS
-          valueFrom:
-            secretKeyRef:
-              key: EXTERNAL_DNS_UNIFI_PASS
+              key: EXTERNAL_DNS_UNIFI_API_KEY
               name: external-dns-unifi-secret
         image:
           repository: ghcr.io/kashalls/external-dns-unifi-webhook
-          tag: v0.3.4@sha256:28dc00c7a21f9571d43181fcc0dd3de59e291741f27bc075d7e06378876b2974
+          tag: pr-85@sha256:9240e65e86499dbbdc3e5b67ba809178dfc8a8bd21155fb3e5e13eb098d8a82b
         livenessProbe:
           httpGet:
             path: /healthz
             port: http-webhook
           initialDelaySeconds: 10
           timeoutSeconds: 5

@bot-ross
Copy link
Contributor

bot-ross bot commented Jan 10, 2025

--- HelmRelease: network/external-dns-unifi Deployment: network/external-dns-unifi

+++ HelmRelease: network/external-dns-unifi Deployment: network/external-dns-unifi

@@ -78,26 +78,21 @@

             port: http
           initialDelaySeconds: 5
           periodSeconds: 10
           successThreshold: 1
           timeoutSeconds: 5
       - name: webhook
-        image: ghcr.io/kashalls/external-dns-unifi-webhook:v0.3.4@sha256:28dc00c7a21f9571d43181fcc0dd3de59e291741f27bc075d7e06378876b2974
+        image: ghcr.io/kashalls/external-dns-unifi-webhook:pr-85@sha256:9240e65e86499dbbdc3e5b67ba809178dfc8a8bd21155fb3e5e13eb098d8a82b
         imagePullPolicy: IfNotPresent
         env:
         - name: UNIFI_HOST
           value: https://192.168.1.1
-        - name: UNIFI_USER
+        - name: UNIFI_API_KEY
           valueFrom:
             secretKeyRef:
-              key: EXTERNAL_DNS_UNIFI_USER
-              name: external-dns-unifi-secret
-        - name: UNIFI_PASS
-          valueFrom:
-            secretKeyRef:
-              key: EXTERNAL_DNS_UNIFI_PASS
+              key: EXTERNAL_DNS_UNIFI_API_KEY
               name: external-dns-unifi-secret
         ports:
         - name: http-webhook
           protocol: TCP
           containerPort: 8080
         livenessProbe:

@onedr0p onedr0p merged commit b056407 into main Jan 10, 2025
10 checks passed
@onedr0p onedr0p deleted the onedr0p-patch-1 branch January 10, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes Changes made in the kubernetes directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant