Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix React 15.5.0 Warnings #176

Closed
wants to merge 2 commits into from

Conversation

andrewzey
Copy link

Problem

  • Get the following React console warnings:
    • warning.js:36 Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.
    • warning.js:36 Warning: Legend: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

Cause

Changes

  • Replace React.PropTypes with prop-types package
  • Replace React.createClass with create-react-class package

@andrewzey andrewzey force-pushed the fix-react-warnings branch from 9a8d509 to 481d987 Compare April 17, 2017 20:50
@andrewzey andrewzey force-pushed the fix-react-warnings branch from 481d987 to 6f1833d Compare April 17, 2017 20:52
@jseminck
Copy link

Any chance of having this merged any time soon?

@natec8
Copy link

natec8 commented Jul 13, 2017

It might be good to fix the failing tests, but if it gets merged in without fixing the tests, I will fix them.

@josephMG josephMG mentioned this pull request Jul 18, 2017
@AlanFoster
Copy link
Member

Thanks for the PR! A newer PR had tests passing, so I've gone ahead and merged that - and I will close this now 👍

@AlanFoster AlanFoster closed this Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants