adeded event.preventDefault() to touchEnd #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for the PR. Out of curiosity, what is your use case for this functionality? |
|
After the user have chosen the range we open a modal on top of the calendar for the user to select from a list of options how they want to mark that range (Available, Unavailable, Primary Booked, Booked). The problem we had without this event.preventDefault() is that the modal got a click / touch on the options directly when it opens so it was closed again. |
|
Thanks! 👍 |
|
@jontelm This is currently available in the latest release candidate, would you mind testing out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added event.preventDefault() to not let the event bubble up to the next component facebook/react#11387