Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove initializeTouchEvents to allow for basic compatibility with 0.… #73

Closed

Conversation

neverfox
Copy link

@neverfox neverfox commented Oct 5, 2015

II don't believe this method has done anything since 0.11, but it's enough to break the component under 0.14.0-rc1. This is one step towards compatibility that will still work >=0.12.0.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…14.0-rc1
@neverfox
Copy link
Author

neverfox commented Oct 5, 2015

Also updates gulp-sass for node 4.1.1 compatibility.

@@ -19,8 +19,6 @@ const PureRenderMixin = React.addons.PureRenderMixin;
const absoluteMinimum = moment(new Date(-8640000000000000 / 2)).startOf('day');
const absoluteMaximum = moment(new Date(8640000000000000 / 2)).startOf('day');

React.initializeTouchEvents(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you not check whether the initializeTouchEvents method exists on React and then call it if it does? That way we can continue to support older versions of React.

@AlanFoster
Copy link
Member

Let's close this PR in favour of #79 which deals with the same problem. Would you mind reviewing that PR too?

@AlanFoster AlanFoster closed this Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants