React 0.14 compatible #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 19, 2015 13:22
|
Will this be merged in soon? |
|
Thanks for the PR! We'll want to get the tests from #72 merged in first, to ensure we haven't broken any functionality in the upgrade. |
Closed
|
Let's close this PR in favour of #79 which deals with the same problem. Would you mind reviewing that PR too? |
|
@AlanFoster It makes sense to merge #79, as it addresses the now-merged tests. Sure, I'd be happy to review, but I won't have the opportunity before Monday, due to annual leave. |
|
@damountie No problem. Thanks for the visibility 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies all recommendations from http://facebook.github.io/react/blog/2015/10/07/react-v0.14.html
Note: there is a still a warning during compilation (which I couldn't immediately see the cause of), and within the Javascript console when using (which is due to the module 'CodeSnippet'). The two may have the same cause.