-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase on top of squashfs-tools-4.5.1 #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not sure where this source is coming from
Needed more logic for compression auto-detection, no longer inlined calls the currently selected decompressor, unless that fails, then tries the other decompressors
CJH: Don't consider this an error, as some implementations omit the size field from the LZMA header
vlaci
force-pushed
the
sasquatch-patches-rebase
branch
2 times, most recently
from
February 28, 2023 21:09
4f30e3b
to
d25a650
Compare
… bug CJH: Temporarily set the default processor count to 1 to prevent threading bug until a proper fix is implemented.
CJH: A generic super block structure used for auto-detecting endianess CJH: Warn if SquashFS magic doesn't look correct CJH: Notify if endianess is different CJH: swap detection already done generically above
CJH: Don't consider it an error if SQUASHFS_MAGIC doesn't match CJH: Added s_major override
This commit fix a bug that happened when building mksquashfs due to the lack of 'override' definition. This allows users to build mksquashfs in big-endian mode to craft v4 big-endian filesystems.
Add big endian support for mksquashfs.
Usable via `nix develop`
Nix packaging and CI jobs
vlaci
force-pushed
the
sasquatch-patches-rebase
branch
from
February 28, 2023 21:31
d25a650
to
56ae6ed
Compare
On OSX, multiple types are not automatically resolved during pre-processing because different implementations of LZMA in the LZMA directory have a file named "LZMA.h". Fixed by renaming them to "LZMA2.h" and "LZMA3.h" while adapting the include macros. Discussion: devttys0/sasquatch#6 (comment)
Add support for OSX
vlaci
force-pushed
the
sasquatch-patches-rebase
branch
from
March 1, 2023 00:10
56ae6ed
to
aa648c4
Compare
vlaci
pushed a commit
to onekey-sec/unblob
that referenced
this pull request
Mar 1, 2023
vlaci
pushed a commit
to onekey-sec/unblob
that referenced
this pull request
Mar 1, 2023
vlaci
pushed a commit
to onekey-sec/unblob
that referenced
this pull request
Mar 1, 2023
vlaci
pushed a commit
to onekey-sec/unblob
that referenced
this pull request
Mar 1, 2023
vlaci
pushed a commit
to onekey-sec/unblob
that referenced
this pull request
Mar 1, 2023
martonilles
approved these changes
Mar 1, 2023
qkaiser
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've opened this PR so that we have a clear view what changes we have on upstream. We can decide to change active branches (as discussed in #11) later.
Done
Rebased
sasquatch
onto upstream's 4.5.1 tagdetails
Removed macOS conditional includes and let Nix include their own. This patch originates fron homebrew as it looks more complete
Tested unblob on x86_64-linux and aarch64-linux
Todo
https://github.com/onekey-sec/unblob/actions/runs/4298778428/jobs/7493287205
Resolves #11