Back to skipping after hooks on one model #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at least by default, you can control it with an argument to the scrub() method now, as well as the env var.
maxfierke
approved these changes
Apr 18, 2022
seems good to restore this behavior since it was a breaking change, but the inconsistency between behavior of before and after hooks and when they're needed to run makes me think there are probably more classes of hooks needed here
|
Yeah, I guess we're just recapitulating the history of RSpec here, before, after, wait do we mean "each", or "all", oh no. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at least by default, you can control it with an argument to the scrub() method now, as well as the env var.