Update the message for undefined scrub #36
Conversation
| @@ -1,3 +1,3 @@ | |||
| module ActsAsScrubbable | |||
| VERSION = '2.1.3' | |||
| VERSION = '2.1.4' | |||
There was a problem hiding this comment.
@adamstegman Updated this
But for a more general question - are the workflows proven out to work? I have been unable to identify the cause of the id error.
It works locally (I hate making that statement) with ruby 3.2.4.
@philton4om ➜ /workspaces/acts_as_scrubbable (no-jira/philton4om-patch-1) $ rspec
Resolving dependencies...
2024-06-13 20:06:11 +0000: [INFO] - Using Upsert
.2024-06-13 20:06:11 +0000: [INFO] - Using Update
.2024-06-13 20:06:11 +0000: [INFO] - Using Update
2024-06-13 20:06:11 +0000: [INFO] - Scrubbing ScrubbableModel ...
2024-06-13 20:06:11 +0000: [INFO] - ScrubbableModel objects scrubbed
2024-06-13 20:06:11 +0000: [INFO] - Scrub Complete!
.2024-06-13 20:06:11 +0000: [INFO] - Using Update
2024-06-13 20:06:11 +0000: [INFO] - Scrubbing ScrubbableModel ...
2024-06-13 20:06:11 +0000: [INFO] - ScrubbableModel objects scrubbed
2024-06-13 20:06:11 +0000: [INFO] - Scrub Complete!
.......................
Finished in 0.95615 seconds (files took 1.08 seconds to load)
26 examples, 0 failures
There was a problem hiding this comment.
You can see the past builds in CircleCI: https://app.circleci.com/pipelines/github/onemedical/acts_as_scrubbable?branch=main. It hasn't been run in 5 months, so something upstream likely changed.
There was a problem hiding this comment.
I take it back—a new branch with no changes passes. So there's something in here it doesn't like. 🤔
There was a problem hiding this comment.
You can reproduce it using the same Rails version as one of the failed jobs:
rbenv shell 3.2.2
export RAILS_VERSION_PREFIX=7.0
bundle install
bundle exec rspec
There was a problem hiding this comment.
Magic! Thank you - was unable to figure out how to do that. I reproduced it and will see what I can do.
There was a problem hiding this comment.
Fixed in 0021ffd! This should be ready to merge (you can ignore the test-head failure, it's a known issue with nulldb).
Update the warning message to delineate the class vs the field.
Example of the old output which had no delination between the class and field:
New change would output