Default build bug

[Tolriq]

Hi,

I'm trying to use your Library and fall into a standard pitfall I guess.
To use last master version I did a simple ant build to get the openiab.jar then add it to my project.

Then use standard code to startSetup.
With only Google Play Store things.

And it crashes with :

java.lang.NoClassDefFoundError: org.onepf.oms.appstore.AmazonAppstoreBillingService
       at org.onepf.oms.appstore.AmazonAppstore.getInAppBillingService(AmazonAppstore.java:101)
       at org.onepf.oms.OpenIabHelper$1.run(OpenIabHelper.java:441)
       at java.lang.Thread.run(Thread.java:841)

That seems logical since the end of the process tries to dispose services and during that phase tries to start the Amazon one that cannot be started due to the missing amazon jar.

There's multiple way to address this I suppose. And not a big problem since I did only wanted to try Google before Amazon and will switch to the openiab-amazon jar.

But I suppose this should be hanlded to help newcomers :)

[oorlov]

Hi @Tolriq!

Added a fix that prevents crash. Probably we need to rename artifact to openiab-no-amazon.jar as well

[Tolriq]

Thanks for that @oorlov

Since I saw some proposed PR from @silent1 are still not merged (But manually fixed in your last commit) I'm not sure if I can PR all the fixes I've found.

But for now as a reference I've merged all known fixes for Play Store handling in my repo :

https://github.com/Tolriq/OpenIAB/commits/master

You may want to look specifically at :
Tolriq@658432d and Tolriq@646f752

As they are simple fixes for common problems without being invasive.

You also may want to look at : Tolriq@7e32072 and associated : Tolriq@6e43f62

That adds some auto reconnect to Play Store service and a specific error code for that for better application handling.

Fell free to cherry pick or I can do PR if you want.

[oorlov]

It would be very helpful if you can make PRs for such commits. I'll revise each of them. I'm sure Google guys don't care about OpenStores compatibility, so I expect work to do to keep compatibility with OpenStores

[Tolriq]

Done, 3 PR so reviewing is easier for you :)

The patch are made by me based on the comments and patch founds, they are tested and should not have impact on OpenStores
They are not blinded copy pastes.