update gradle build scripts to be consistent; cleanup AndroidManifest files #253
Conversation
cleanup AndroidManifest files
| @@ -15,13 +15,7 @@ | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~--> | |||
|
|
|||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | |||
| package="org.onepf.oms" | |||
There was a problem hiding this comment.
Remove description of application vesrionCode, versionName and used sdk version from AndroidManifest it's not good. Not all IDEs support Android NBS, and they get app properties from AndroidManifest.
There was a problem hiding this comment.
Might be a good point.
However I think it's best to concentrate on AndroidStudio support.
Though, even AndroidStudion don't fully support new build system yet. For example package attribute is no longer needed - it's replaced with applicationId from build.gradle. It's left in place for backward compatibility with Manifest syntax checkers.
There was a problem hiding this comment.
I know that some of attributes in AndroidManifest no longer need because they set from build.gradle. But I can't work with NBS from Eclipse. Some of developer use Eclipse with NDK, because AndroidStudio and IDEA hasn't support it. That's why no need to remove this attrs from AndroidManifest. We already merged NBS support in #251.
There was a problem hiding this comment.
I saw NBS merged, and built my pull request on top of it. I only wanted for build scripts to be clean and consistent.
Final Manifest format is up to @akarimova, I can update my pull request if needed.
There was a problem hiding this comment.
Revert all changes in AndroidManifest.
|
After some painful experience I was able to run Gradle Android project from Eclipse using this plugin. |
|
In post http://forums.gradle.org/gradle/topics/revolutionary_new_gradle_features_on_the_2014_roadmap in section "Tooling and IDE support" Gradleware talks about Gradle Eclipse plugin. |
|
They probably meant "official" plugin which is not quite there yet. I tried it first, but with no luck. P.S. I updated this pull request. |
update gradle build scripts to be consistent; cleanup AndroidManifest files
No description provided.