Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Cash basis #22

Closed
ThijsvOers opened this issue Aug 22, 2023 · 6 comments
Closed

Hide Cash basis #22

ThijsvOers opened this issue Aug 22, 2023 · 6 comments

Comments

@ThijsvOers
Copy link
Contributor

Hide cash basis when NL invoice basis is True (on the settings menu)
@astirpe astirpe self-assigned this Aug 23, 2023
@astirpe
Copy link
Contributor

astirpe commented Aug 23, 2023

Done in onesteinbv/addons-oca@be1703e

@astirpe astirpe removed their assignment Aug 23, 2023
@ThijsvOers ThijsvOers added the enhancement New feature or request label Aug 29, 2023
@ThijsvOers
Copy link
Contributor Author

Testes and ok

@ThijsvOers ThijsvOers reopened this Oct 19, 2023
@ThijsvOers
Copy link
Contributor Author

@astirpe I just saw that in the latest test db (with latest changes) the cash basis checkbox is visible again. I tested this with the 'onestein' user account (where the settings menu is visible)

image

@astirpe
Copy link
Contributor

astirpe commented Oct 19, 2023

Opened an OCA PR OCA/l10n-netherlands#402 to avoid that the fix will be overwritten again.
@ThijsvOers can you approve the OCA PR?

@astirpe
Copy link
Contributor

astirpe commented Oct 19, 2023

Restored in onesteinbv/addons-oca@da59d0b

@astirpe astirpe added the test label Oct 19, 2023
@ThijsvOers ThijsvOers removed their assignment Oct 20, 2023
@ThijsvOers ThijsvOers removed enhancement New feature or request test labels Oct 20, 2023
@ThijsvOers
Copy link
Contributor Author

Tested and ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@astirpe @ThijsvOers