Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] l10n_nl_tax_statement: hide cash-basis when NL invoice-basis #402

Merged
merged 1 commit into from
Nov 16, 2023
Merged

[16.0][FIX] l10n_nl_tax_statement: hide cash-basis when NL invoice-basis #402

merged 1 commit into from
Nov 16, 2023

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Oct 19, 2023

Hide cash basis when NL invoice basis is True (on the settings).

CC @ThijsvOers

@astirpe astirpe mentioned this pull request Oct 19, 2023
Closed
ThijsvOers
ThijsvOers approved these changes Oct 19, 2023
View reviewed changes
Copy link

@ThijsvOers ThijsvOers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and ok, cash basis is hidden once NL Tax Invoice basis is set to True

NL66278
NL66278 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@NL66278
Copy link
Contributor

NL66278 commented Nov 16, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-402-by-NL66278-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4b86f0f into OCA:16.0 Nov 16, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4b86f0f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThijsvOers ThijsvOers ThijsvOers approved these changes

@NL66278 NL66278 NL66278 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@astirpe @OCA-git-bot @NL66278 @ThijsvOers