Add notSkipAlphaChannel options. #136
Conversation
Source/APNGKit/APNGDecoder.swift
Outdated
| @@ -29,6 +29,7 @@ class APNGDecoder { | |||
| let reader: Reader | |||
| let options: APNGImage.DecodingOptions | |||
| let cachePolicy: APNGImage.CachePolicy | |||
| let usesPrimitiveTrueColorAlphaChannel: Bool | |||
There was a problem hiding this comment.
Do we actually need this here? Seems this property is only used in APNGImageRenderer when creating the bitmap info, so maybe just reading the options in the renderer class can be better (so we can eliminate the property)?
There was a problem hiding this comment.
Thank you for your review.
I moved this parameter to APNGImageRenderer and APNGImageView.
There was a problem hiding this comment.
Thanks for it! I will merge it and then do some smaller adjustments to make the APIs more generic.
Revert "add usesPrimitiveTrueColorAlphaChannel options" This reverts commit 5103792. Update APNGImageRenderer.swift add shouldRenderWithAlpha add paramter
|
After some revise of the PNG spec, I guess I misunderstood the original meaning of |
It looks the WebKit always lookup alpha channel regardless of color type.
This APNG image has a color type that is true color(2).
But, Safari renders it with alpha channel.
So, I added
notSkipAlphaChanneltoDecodingOptions.This option always uses alpha channel when color type is true color.
I would like you to review my architecture, variable names and proposal.