UCL-563 Data grid datetime picker #748
Conversation
|
package.json
Outdated
| @@ -134,5 +134,8 @@ | |||
| "ts-jest": "^29.1.5", | |||
| "tslib": "^2.6.3", | |||
| "typescript": "^5.5.3" | |||
| }, | |||
| "dependencies": { | |||
| "date-fns": "^4.1.0" | |||
There was a problem hiding this comment.
Maybe it should be a peer dependency too? @pawel-napieracz wdyt?
| const { dataGrid, getAllByRole } = createDataGridWithDateFilter(); | ||
|
|
||
| expect(dataGrid).toBeInTheDocument(); | ||
|
|
There was a problem hiding this comment.
| await userEvent.clear(toInput); | ||
| await userEvent.type(toInput, "not a date[Tab]"); | ||
|
|
||
| expect(getAllByText("The format must be yyyy-mm-dd hh:mm:ss")).toHaveLength(2); |
There was a problem hiding this comment.
I would split the test into custom dates / field validation, and add more error cases (like the ones reported by Scott
| <Fragment> | ||
| <Icon icon={Icons.Calendar} /> | ||
| <Typography variant="body" className={classes["caption"]}> | ||
| Date is <b>{dateTagCaption}</b> |
There was a problem hiding this comment.
We should be able to localize all the texts
| to: "To", | ||
| cancel: "Cancel", | ||
| apply: "Apply", | ||
| dateInputPlaceholder: "yyyy-mm-dd hh:mm:ss" |
There was a problem hiding this comment.
Please, extract to a static and refer to the format in other places (such as above, in the error message)
| return ( | ||
| <Fragment> | ||
| <InputWrapper | ||
| style={{ marginTop: 0, maxWidth: "224px" }} |
There was a problem hiding this comment.
Why passing the style like this?
| <InputWrapper | ||
| style={{ marginTop: 0, maxWidth: "224px" }} | ||
| label={from} | ||
| name={"fromDate"} |
There was a problem hiding this comment.
| name={"fromDate"} | |
| name="fromDate" |
to me it's ok, but @pawel-napieracz hunts me with this :D
| @@ -66,6 +76,7 @@ export const DatePicker = ({ onSelect, value, required, mode, locale, ...rest }: | |||
| {...rest} | |||
| {...commonProps} | |||
| mode={mode} | |||
| endMonth={new Date(3000, 12)} | |||
| ], | ||
| isLoading: false, | ||
| enableMultiSorting: true | ||
| }; |
There was a problem hiding this comment.
Please, add the entry with play function that will open the filter
| } | ||
| } | ||
| }; | ||
| return ( |
There was a problem hiding this comment.
Some months take more height than others. This makes the entire modal "jump" a little. I don't think it's a big issue but would be nice to discuss with the UX.
No description provided.