build: rename ".czrc.json" to supported ".czrc" #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview d01b132 has been successfully built and deployed to https://onfido-castor-icons-preview-pr-78.surge.sh 🕐 Build time: 24.234s
🤖 By surge-preview |
rabelloo
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
After latest upgrade of
commitizen, we no longer were able to commit via CLI (without using-m).Turns out this latest release reverts a feature that was accidentally released as a patch but not a major version.
That feature did not require to setup
cz-conventional-changelogvia.czrcfile anymore (as it would come as a default).After reverting the feature, everything should still function as expected because we still had a manual configuration done as instructed, but with using
.czrc.jsoninstead of.czrc(hence the file extension added). The config file was not picked up bycommitizen, and so it was not working properly anymore.Approach
Rename
.czrc.jsonto.czrc.Testing
Tested manually locally.
Risks
N/A