fix(react): button type overloads (#1053)

onfido · Oct 12, 2021 · da8e865 · da8e865 · vercel · Oct 12, 2021
1 parent 8a3664d
commit da8e865
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/react/src/components/button/button.tsx b/packages/react/src/components/button/button.tsx
@@ -29,11 +29,13 @@ export const Button: ButtonComponent = withRef(function Button(
 });
 
 export type ButtonProps<T extends 'a' | 'button' = 'button'> = BaseProps &
-  (T extends 'a' ? AnchorElementProps : ButtonElementProps);
+  (T extends 'a'
+    ? { href: string } & AnchorElementProps
+    : { href?: never } & ButtonElementProps);
 
 type ButtonComponent = {
-  (props: BaseProps & AnchorElementProps, ref: AnchorRef): JSX.Element;
-  (props: BaseProps & ButtonElementProps, ref: ButtonRef): JSX.Element;
+  (props: ButtonProps<'a'>, ref: AnchorRef): JSX.Element;
+  (props: ButtonProps<'button'>, ref: ButtonRef): JSX.Element;
 };
 
 type AnchorElementProps = JSX.IntrinsicElements['a'] & { ref?: AnchorRef };