fix(react): select should respond to value changes #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/onfido-oss/castor/4C7STpZa7G8BfoEph33wmrNE9bfB |
josokinas
approved these changes
Nov 26, 2021
Co-authored-by: Julius Osokinas <20243687+josokinas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
React's
<Select />does not update when itsvaluechanges, but it should.Approach
Introduce
useEffecthooks that set internal value when it changes.Also change
initializea bit so that the correct option JSX can be found with its value as key.Testing
Storybook with
valueproperty defined and changed with, for example, hooks and buttonsRisks
Slightly increases
Select's bundle size