feat: generate tokens with theo #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😭 Deploy PR Preview caee119 failed. Build logs
🤖 By surge-preview |
josokinas
force-pushed
the
feat/theo-tokens
branch
from
3871f01 to
544c06f
Compare
|
The build is failing because workflow runs out of main branch, and this now has adjustment to generate the token. Once merged it will start passing. |
rabelloo
approved these changes
Jan 4, 2021
Co-authored-by: Andre Luiz Rabello <andre.luiz_r@hotmail.com>
josokinas
force-pushed
the
feat/theo-tokens
branch
from
f4010b7 to
caee119
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In order to (later) generate tokens not only for web, but also for iOS and Android, we need one source of aliases & tokens in a format that can be used to generate multi-platform variants.
Approach
Using Theo to generate (for now) web tokens.
I had an idea of running script each time either
aliases.jsonortokens.jsongets modified, then commit thetokens.scssto Git, however due to issues I gave up, also not sure havingtokens.scssin the repo would be much benefitial.Testing
Tested locally, pipeline should also pass, preview generated.
Risks
N/A