fix(react): export search component #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview 94fe319 has been successfully built and deployed to https://onfido-castor-preview-pr-141.surge.sh 🕐 Build time: 105.167s
🤖 By surge-preview |
sanchapereira
approved these changes
Dec 31, 2020
posthardcode
approved these changes
Dec 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Export Search component for React.
Component can still be used, however can't be
import { Search } from "@onfido/castor-react".Approach
Add to main component exports of React package.
Testing
Tested locally.
Risks
This might repeat for future components, @rabelloo we should think of testing the export of all components.